-
Notifications
You must be signed in to change notification settings - Fork 774
Feat: Add Support for Cookie Attributes in Session Affinity #1826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add Support for Cookie Attributes in Session Affinity #1826
Conversation
|
@stefanprodan @aryan9600 Any thoughts? |
Signed-off-by: Renato Vassão <[email protected]>
Signed-off-by: Renato Vassão <[email protected]>
Signed-off-by: Renato Vassão <[email protected]>
Signed-off-by: Renato Vassão <[email protected]>
b67d81d to
0dd9fe9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the docs with all new fields here: https://docs.flagger.app/usage/deployment-strategies#canary-release-with-session-affinity
The source is here: https://github.com/fluxcd/flagger/blob/main/docs/gitbook/usage/deployment-strategies.md#configuring-stickiness-for-primary-deployment
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1826 +/- ##
===========================================
- Coverage 39.44% 28.91% -10.54%
===========================================
Files 287 287
Lines 22706 22909 +203
===========================================
- Hits 8956 6623 -2333
- Misses 12777 15561 +2784
+ Partials 973 725 -248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Renato Vassão <[email protected]>
5e873a8 to
fab4540
Compare
|
Thanks for the review @stefanprodan, updated docs with new functionality. |
stefanprodan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @renatovassaomb
Summary
Adding support for specifying all cookie attributes to Session Affinity except
Expires, which doesn't look like it would be useful.Fixes #1527
Changes
Testing
References